Skip to content

Address some Sonar warnings#14879

Merged
brettcannon merged 4 commits into
microsoft:mainfrom
brettcannon:sonar-2020-12-03
Dec 4, 2020
Merged

Address some Sonar warnings#14879
brettcannon merged 4 commits into
microsoft:mainfrom
brettcannon:sonar-2020-12-03

Conversation

@brettcannon
Copy link
Copy Markdown
Member

@brettcannon brettcannon commented Dec 3, 2020 •
edited
Loading

Along the way, also address eslint issues for condaService.ts that appeared after editing the file for the file's Sonar fix.

@brettcannon brettcannon added the no-changelog No news entry required label Dec 3, 2020
@brettcannon brettcannon requested a review from int19h December 3, 2020 22:09
int19h
int19h reviewed Dec 3, 2020
View reviewed changes
Comment thread src/client/common/application/debugSessionTelemetry.ts Outdated
ericsnowcurrently
ericsnowcurrently approved these changes Dec 4, 2020
View reviewed changes
Copy link
Copy Markdown

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brettcannon brettcannon requested a review from int19h December 4, 2020 00:49
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 4, 2020

Codecov Report

Merging #14879 (bec0aeb) into main (5533608) will increase coverage by 0%.
The diff coverage is 57%.

@@          Coverage Diff           @@
##            main   #14879   +/-   ##
======================================
  Coverage     65%      65%           
======================================
  Files        551      551           
  Lines      25889    25895    +6     
  Branches    3672     3672           
======================================
+ Hits       16902    16906    +4     
- Misses      8294     8296    +2     
  Partials     693      693
Impacted Files Coverage Δ
...lient/activation/languageServer/analysisOptions.ts 58% <ø> (ø)
...client/common/application/debugSessionTelemetry.ts 20% <0%> (-1%) ⬇️
src/client/common/cancellation.ts 38% <ø> (ø)
...scovery/locators/services/baseVirtualEnvService.ts 27% <0%> (ø)
.../client/testing/common/managers/baseTestManager.ts 45% <0%> (ø)
...nments/discovery/locators/services/condaService.ts 83% <69%> (-1%) ⬇️
src/client/common/installer/condaInstaller.ts 100% <100%> (ø)
src/client/common/terminal/activator/base.ts 81% <100%> (ø)
...ugger/extension/hooks/childProcessAttachHandler.ts 100% <100%> (ø)
src/client/testing/common/debugLauncher.ts 90% <100%> (ø)
... and 3 more

@brettcannon brettcannon merged commit 38709f2 into microsoft:main Dec 4, 2020
@brettcannon brettcannon deleted the sonar-2020-12-03 branch December 4, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthiknadig karthiknadig Awaiting requested review from karthiknadig

2 more reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@int19h int19h int19h approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@brettcannon brettcannon

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brettcannon @codecov-io @ericsnowcurrently @int19h