Added workspace virtualenv filesystem watcher#14780
Merged
Merged
Conversation
added 2 commits
November 19, 2020 13:16
|
Kudos, SonarCloud Quality Gate passed!
|
4904f16 to
c9139ed
Compare
added 2 commits
November 19, 2020 22:42
ead59c3 to
641c186
Compare
added 3 commits
November 19, 2020 23:43
karrtikr
commented
Nov 20, 2020
|
|
||
| const workspaceLocators = new WorkspaceLocators([ | ||
| // Add an ILocator factory func here for each kind of workspace-rooted locator. | ||
| (root: vscode.Uri) => [new WorkspaceVirtualEnvironmentLocator(root.fsPath)], |
Author
There was a problem hiding this comment.
Connecting this locator to the external surface changes quite a few things, will do that in a separate PR.
kimadeline
reviewed
Nov 20, 2020
kimadeline
approved these changes
Nov 20, 2020
karthiknadig
approved these changes
Nov 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.