Re-implement conda tool discovery in a separate uncoupled component.#14745
Merged
Conversation
Author
|
Note that this is not the locator itself, but rather the wrapper around |
int19h
commented
Nov 16, 2020
int19h
commented
Nov 16, 2020
| } | ||
| yield* getCandidatesFromKnownPaths(); | ||
| yield* getCandidatesFromEnvironmentsTxt(); | ||
| } |
Author
There was a problem hiding this comment.
Some of these functions don't really need to be generators, but it's a bit more readable when it's consistent.
int19h
commented
Nov 16, 2020
|
@int19h The auto assign bot is still in effect, so everyone is being assigned. Removed the unintended reviewers. |
kimadeline
approved these changes
Nov 17, 2020
d3e2340 to
c7b8674
Compare
karthiknadig
approved these changes
Nov 19, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).