Skip to content

Port compiler fix (#14460)#14484

Merged
joyceerhl merged 1 commit into
mainfrom
compiler-fix
Oct 22, 2020
Merged

Port compiler fix (#14460)#14484
joyceerhl merged 1 commit into
mainfrom
compiler-fix

Conversation

@joyceerhl

@joyceerhl joyceerhl commented Oct 22, 2020

Copy link
Copy Markdown

Also adds experiment to insiders

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@joyceerhl joyceerhl added the no-changelog No news entry required label Oct 22, 2020
@sonarqubecloud

sonarqubecloud Bot commented Oct 22, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io

codecov-io commented Oct 22, 2020

Copy link
Copy Markdown

Codecov Report

Merging #14484 into main will decrease coverage by 0.00%.
The diff coverage is 54.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #14484      +/-   ##
==========================================
- Coverage   59.29%   59.28%   -0.01%     
==========================================
  Files         719      720       +1     
  Lines       40315    40332      +17     
  Branches     5849     5849              
==========================================
+ Hits        23903    23912       +9     
- Misses      15151    15159       +8     
  Partials     1261     1261
Impacted Files Coverage Δ
...ience/interactive-common/interactiveWindowTypes.ts 100.00% <ø> (ø)
src/client/telemetry/index.ts 80.41% <ø> (ø)
src/client/datascience/commands/commandRegistry.ts 34.76% <25.00%> (+0.23%) ⬆️
...ata-viewing/debuggerDataViewerExperimentEnabler.ts 42.85% <42.85%> (ø)
src/client/common/serviceRegistry.ts 100.00% <100.00%> (ø)
src/client/datascience/constants.ts 99.78% <100.00%> (-0.01%) ⬇️
src/client/telemetry/constants.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4333fc0...c6d8bbb. Read the comment docs.

@joyceerhl
joyceerhl merged commit 97cd456 into main Oct 22, 2020
@joyceerhl
joyceerhl deleted the compiler-fix branch October 22, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joyceerhl @codecov-io @karthiknadig