Codecov Report

Merging #14413 into main will decrease coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #14413      +/-   ##
==========================================
- Coverage   59.40%   59.19%   -0.22%     
==========================================
  Files         716      720       +4     
  Lines       39999    40211     +212     
  Branches     5793     5829      +36     
==========================================
+ Hits        23763    23802      +39     
- Misses      14975    15147     +172     
- Partials     1261     1262       +1     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76e6e28...cb01d9b. Read the comment docs.

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
No Duplication information

@rchiodo would you mind reviewing this PR?
Thank you!

Thanks @rchiodo for the review.
Concerning those merge conflicts, would you possibly resolve that? Or if you want me to open a new PR?

You should be able to resolve them in this PR.

Just rebase or merge with main and push the change again.

Just rebase or merge with main and push the change again.

I don't understand why plotly.js is now removed from dependencies on the main branch after #14447.
@rchiodo @nicolaskruchten could you please have a look?

Hi @archmoj, We're really sorry for the inconvenience and want to minimize the delay for changes you're working on. However, we are in the end stages of a restructuring to enable a more manageable relationship with the Python core extension's codebase. We're getting very close to having this completed and once we do we will make a more public statement about it. Please stay tuned.

Hi @greazer, is there a place I find more information on this restructuring and timelines?

Our concern is that the plotly python module requires an up to date version of Plotly.js to be available in VSCode-python for notebook users to have a good experience with our new features :)

This needs to be ported to the new source.

@rchiodo we'd be happy to! Where is the new source?

Sorry that's not public yet. Should be soon. I'll comment here when it's possible to move it to the new location.

It seems like the right place to do this now (or at least an additional place to do it!) is here https://github.com/microsoft/vscode-jupyter/blob/main/package.json#L1812

@archmoj can you please submit the equivalent PR there for 1.57.1, and continue to do so there from now on?

It seems like the right place to do this now (or at least an additional place to do it!) is here https://github.com/microsoft/vscode-jupyter/blob/main/package.json#L1812

@archmoj can you please submit the equivalent PR there for 1.57.1, and continue to do so there from now on?

@nicolaskruchten Done in microsoft/vscode-jupyter#1083.