Add Registry Locator#14349
Conversation
Codecov Report
@@ Coverage Diff @@
## main #14349 +/- ##
==========================================
- Coverage 59.81% 59.40% -0.42%
==========================================
Files 709 716 +7
Lines 39414 39999 +585
Branches 5712 5793 +81
==========================================
+ Hits 23577 23762 +185
- Misses 14598 14976 +378
- Partials 1239 1261 +22
Continue to review full report at Codecov.
|
kimadeline
left a comment
There was a problem hiding this comment.
Looks good to me. Not going to block on this, but could you fix the [spaces](https://github.com/airbnb/javascript#whitespace--before-blocks and spaces) before merging? Thanks!
| searchLocation?: Uri; | ||
| }; | ||
|
|
||
| export const UNKNOWN_PYTHON_VERSION:PythonVersion = { |
There was a problem hiding this comment.
Not specific to this PR, but here you introduce the UNKNOWN_PYTHON_VERSION constant, then in src/client/common/utils/version.ts we have
vscode-python/src/client/common/utils/version.ts
Lines 72 to 81 in ff60b40
and in src/client/pythonEnvironments/base/info/env.ts we have buildEnvInfo that builds an empty env object, with almost the same field data.
It would be nice if we could have all these constants living together somewhere 😐
There was a problem hiding this comment.
We need to bring all of these together. Likely we will need to do a final polish when we are done with the functional bits.
There was a problem hiding this comment.
Is it too early to create a work item for this, or do you think we'll remember to do this when we're done?
| try { | ||
| version = parseVersion(versionStr); | ||
| } catch (ex) { | ||
| version = { |
There was a problem hiding this comment.
Why not use UNKNOWN_PYTHON_VERSION here?
|
Kudos, SonarCloud Quality Gate passed!
|
* Add Registry Locator * Address comments
No description provided.