Skip to content

Update NativeNotebook types in type definition#13527

Merged
DonJayamanne merged 3 commits into
microsoft:masterfrom
DonJayamanne:updateTypes
Aug 19, 2020
Merged

Update NativeNotebook types in type definition#13527
DonJayamanne merged 3 commits into
microsoft:masterfrom
DonJayamanne:updateTypes

Conversation

@DonJayamanne
Copy link
Copy Markdown

For #12189

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Aug 19, 2020
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 19, 2020

Codecov Report

Merging #13527 into master will decrease coverage by 0.03%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13527      +/-   ##
==========================================
- Coverage   59.78%   59.74%   -0.04%     
==========================================
  Files         670      670              
  Lines       37363    37371       +8     
  Branches     5357     5361       +4     
==========================================
- Hits        22337    22327      -10     
- Misses      13871    13882      +11     
- Partials     1155     1162       +7     
Impacted Files Coverage Δ
...datascience/notebookStorage/nativeEditorStorage.ts 66.82% <ø> (-0.65%) ⬇️
...nt/datascience/notebookStorage/vscNotebookModel.ts 59.25% <0.00%> (-6.65%) ⬇️
...rc/client/datascience/notebookStorage/baseModel.ts 67.42% <50.00%> (ø)
...ience/interactive-ipynb/nativeEditorViewTracker.ts 87.50% <100.00%> (-0.31%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/datascience/crossProcessLock.ts 79.41% <0.00%> (-11.77%) ⬇️
src/client/common/utils/misc.ts 73.33% <0.00%> (-2.23%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 151720a...596e429. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@DonJayamanne DonJayamanne merged commit fec21d0 into microsoft:master Aug 19, 2020
@DonJayamanne DonJayamanne deleted the updateTypes branch August 19, 2020 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants