Fix a policheck warning.#13325
Merged
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #13325 +/- ##
==========================================
- Coverage 59.73% 59.71% -0.03%
==========================================
Files 670 670
Lines 37289 37289
Branches 5292 5292
==========================================
- Hits 22276 22267 -9
- Misses 13879 13885 +6
- Partials 1134 1137 +3
Continue to review full report at Codecov.
|
karthiknadig
approved these changes
Aug 7, 2020
Author
|
Oh, turns out I do have merge permissions now. Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm fixing PoliCheck warnings in PTVS repo and since this one originates from this repo, I'm submitting a fix for it here as well.
Please merge on my behalf, I do not have merge permissions. Thanks!
Has a news entry file (remember to thank yourself!).Appropriate comments and documentation strings in the code.Has sufficient logging.Has telemetry for enhancements.Unit tests & system/integration tests are added/updated.Test plan is updated as appropriate.package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).The wiki is updated with any design decisions/details.