Skip to content

Bump plotly.js to 1.54.5#12609

Merged
rchiodo merged 2 commits into
microsoft:masterfrom
nicolaskruchten:patch-1
Jul 1, 2020
Merged

Bump plotly.js to 1.54.5#12609
rchiodo merged 2 commits into
microsoft:masterfrom
nicolaskruchten:patch-1

Conversation

@nicolaskruchten

@nicolaskruchten nicolaskruchten commented Jun 26, 2020

Copy link
Copy Markdown

@nteract/transform-plotly no longer depends on @nteract/plotly but rather plotly.js-dist and this PR bumps to the latest version thereof.

@karthiknadig
karthiknadig requested a review from rchiodo June 30, 2020 07:42
rchiodo
rchiodo requested changes Jun 30, 2020
View reviewed changes

@rchiodo rchiodo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we also need to upgrade nteract/transform-plotly? Or does it already have this dependency with the version we have?

@nicolaskruchten

nicolaskruchten commented Jul 1, 2020

Copy link
Copy Markdown
Author

As far as I know @nteract/transform-plotly accepts plotly.js at or higher than some version, and 1.54.5 is compatible with this, so bumping it here explicitly will cause @nteract/transform-plotly to use the desired version (I see no lockfile suggesting this won't happen). I've also submitted a PR upstream nteract/outputs#13 which was merged but I don't know when it'll be released.

@rchiodo

rchiodo commented Jul 1, 2020

Copy link
Copy Markdown

Okay thanks. The build errors are related to not running npm install after updating the package.json. If you can fix that I'll submit the pr.

@nicolaskruchten

nicolaskruchten commented Jul 1, 2020

Copy link
Copy Markdown
Author

Ah what do you know, "I see no lockfile" doesn't mean "there isn't a lockfile" :)

What version of npm do I need to regenerate a compatible lockfile with minimal changes?

@nicolaskruchten

nicolaskruchten commented Jul 1, 2020

Copy link
Copy Markdown
Author

npm v6 will do it :)

@sonarqubecloud

sonarqubecloud Bot commented Jul 1, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@rchiodo rchiodo added the no-changelog No news entry required label Jul 1, 2020
@rchiodo

rchiodo commented Jul 1, 2020

Copy link
Copy Markdown

Thanks, build passed. I'll submit.

@rchiodo
rchiodo merged commit ab1eadf into microsoft:master Jul 1, 2020
@archmoj archmoj mentioned this pull request Sep 3, 2020
Merged
1 task
@joyceerhl joyceerhl mentioned this pull request Sep 21, 2020
Merged
9 tasks
@nicolaskruchten nicolaskruchten mentioned this pull request Jul 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rchiodo rchiodo rchiodo approved these changes

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nicolaskruchten @rchiodo @karthiknadig