Jupyter hub preliminary support#12574
Merged
Merged
Conversation
DonJayamanne
requested changes
Jun 25, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
DonJayamanne
approved these changes
Jun 25, 2020
IanMatthewHuff
approved these changes
Jun 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #9679
Added to our jupyter password connect info to make it such that it would also connect to jupyter hub. The password connect will also return a new URL if necessary (as might happen when logging in).
Added a unit test for the hub connection and added manual test steps to the test plan.
Preliminary because I've only tested with docker containers. Not sure if there are other configurations that might not work as well.