Move code related to Python version to the py-envs component tree.#12236
Conversation
64e83fc to
1e7e366
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
kimadeline
left a comment
There was a problem hiding this comment.
Is GitHub not letting me reply to comments because I'm halfway through a review, or because the comments are outdated 🤔
Anyway:
Regardless, while that airbnb link is a little unclear (I could get rid of the
* aspart of the line?), the Typescript docs indicate that individual names should be imported unless a bunch of stuff is being imported. I don't mind going with convention even if I don't agree with it. 😄
Yeah that's what I was referring to 👍
In this case it is so it is more clear in the test code what names belong to the system-under-test, as opposed to supporting the tests. I drew inspiration from Graham's talk, where he suggested explicitly identifying the system-under-test in tests.
Oh, that's what sut stood for 🙈 I actually didn't find the namespace clearer, since its meaning wasn't obvious to me. I don't think it brings any extra value when we already have the name of the test file, the test description and the "initialization-test calls-result checking" structure of each test.
This mostly involves moving code, and only minor refactoring (to pull the component code out of the DI-based classes).
[ ] Has a news entry file (remember to thank yourself!).[ ] Appropriate comments and documentation strings in the code.[ ] Has sufficient logging.[ ] Has telemetry for enhancements.[ ] Unit tests & system/integration tests are added/updated.[ ] Test plan is updated as appropriate.[ ]package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).[ ] The wiki is updated with any design decisions/details.