Skip to content

Replace typo unitest to unittest.#12061

Merged
kimadeline merged 4 commits into
microsoft:masterfrom
Rxmeez:update/10919-typo-unitest
Jun 3, 2020
Merged

Replace typo unitest to unittest.#12061
kimadeline merged 4 commits into
microsoft:masterfrom
Rxmeez:update/10919-typo-unitest

Conversation

@Rxmeez
Copy link
Copy Markdown

@Rxmeez Rxmeez commented May 29, 2020 •
edited
Loading

For #10919

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@msftclas
Copy link
Copy Markdown

msftclas commented May 29, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

kimadeline
kimadeline suggested changes Jun 1, 2020
View reviewed changes
Copy link
Copy Markdown

@kimadeline kimadeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we accept this change the typo in the src/test/pythonFiles/testFiles/unitestsWithConfigs folder name should also be fixed.

@kimadeline
Copy link
Copy Markdown

kimadeline commented Jun 1, 2020

The files got deleted, not moved.

@karthiknadig
Copy link
Copy Markdown
Member

karthiknadig commented Jun 2, 2020

@Rxmeez can you provide a news item, so you get the credit for this change?
See this for example: https://github.com/microsoft/vscode-python/pull/11720/files#diff-ee964e4973ca0dd0d510acfc57a078d3

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Rxmeez Rxmeez requested a review from kimadeline June 3, 2020 13:18
kimadeline
kimadeline approved these changes Jun 3, 2020
View reviewed changes
Copy link
Copy Markdown

@kimadeline kimadeline left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Let me run the CI pipeline against your PR (which we do for all external contributor PRs), and once it passes I'll merge it.

Status is being reported here: https://dev.azure.com/ms/vscode-python/_build/results?buildId=85203&view=results

Thank you for your contribution 🙂

@kimadeline kimadeline merged commit 3df06fe into microsoft:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kimadeline kimadeline kimadeline approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Rxmeez @msftclas @kimadeline @karthiknadig