Ensure we can use proposed VS Code API with ts-node - #12038
Merged
Don Jayamanne (DonJayamanne) merged 2 commits intoMay 28, 2020
Merged
Ensure we can use proposed VS Code API with ts-node#12038Don Jayamanne (DonJayamanne) merged 2 commits into
Don Jayamanne (DonJayamanne) merged 2 commits into
Conversation
Don Jayamanne (DonJayamanne)
requested a review
from Karthik Nadig (karthiknadig)
May 28, 2020 16:13
Don Jayamanne (DonJayamanne)
marked this pull request as ready for review
May 28, 2020 16:13
Joyce Er (joyceerhl)
approved these changes
May 28, 2020
|
|
||
| suite('Data Science - NativeNotebook ContentProvider', () => { | ||
| // tslint:disable: no-any | ||
| suite('Data Science - NativeNotebook ContentProviderxxx', () => { |
There was a problem hiding this comment.
Remove xxx for grepping :)
Ian Huff (IanMatthewHuff)
approved these changes
May 28, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Karthik Nadig (karthiknadig)
approved these changes
May 28, 2020
Tim Ruscica (techwithtim)
pushed a commit
to techwithtim/vscode-python
that referenced
this pull request
May 28, 2020
* Use a proxy type for propsed types (for ts-node) * Oh yes `ts-node` sucks, cuz it doesn't work the same way as `tsc` compiler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #12025
ts-nodesucks (things work when using tsc compiler, but not with ts-node).