Allow LS to be bundled, versioned - #12034
Merged
Merged
Conversation
|
LGTM. Eric Snow (@ericsnowcurrently) may want to approve. |
Member
Author
|
Actually, one thing I may want to do is rename the folder so that it's not the same as the local copy that gets run. That way there's no ambiguity as to where it comes from if we are doing local development. Don't merge this quite yet, want to see if that turns out to be better... |
Eric Snow (ericsnowcurrently)
suggested changes
Jun 1, 2020
Eric Snow (ericsnowcurrently)
left a comment
There was a problem hiding this comment.
mostly LGTM
I've left a few comments, mostly for clarificaiton and some very minor changes.
Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the download to be skipped and a pinned version to be used instead.
Has a news entry file (remember to thank yourself!).Has telemetry for enhancements.Test plan is updated as appropriate.package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).The wiki is updated with any design decisions/details.