Skip to content

Changes to how debug options are passed into the experimental version of PTVSD (debugger)#1195

Merged
DonJayamanne merged 2 commits into
microsoft:masterfrom
DonJayamanne:issue1168DebugOptions
Mar 26, 2018
Merged

Changes to how debug options are passed into the experimental version of PTVSD (debugger)#1195
DonJayamanne merged 2 commits into
microsoft:masterfrom
DonJayamanne:issue1168DebugOptions

Conversation

@DonJayamanne
Copy link
Copy Markdown

@DonJayamanne DonJayamanne commented Mar 26, 2018

Fixes #1168

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@DonJayamanne DonJayamanne changed the title Issue1168 debug options Changes to how debug options are passed into the experimental version of PTVSD (debugger) Mar 26, 2018
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 26, 2018 •
edited
Loading

Codecov Report

Merging #1195 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1195      +/-   ##
==========================================
+ Coverage   71.96%   71.99%   +0.02%     
==========================================
  Files         260      260              
  Lines       11922    11930       +8     
  Branches     2116     2118       +2     
==========================================
+ Hits         8580     8589       +9     
+ Misses       3219     3216       -3     
- Partials      123      125       +2
Impacted Files Coverage Δ
...lient/debugger/configProviders/pythonV2Provider.ts 100% <100%> (ø) ⬆️
...c/client/debugger/DebugClients/LocalDebugClient.ts 52.41% <100%> (+0.38%) ⬆️
src/client/debugger/Common/Contracts.ts 100% <100%> (+10.41%) ⬆️
...rc/client/debugger/configProviders/baseProvider.ts 93.05% <100%> (+0.09%) ⬆️
src/client/unittests/common/debugLauncher.ts 93.18% <100%> (+0.15%) ⬆️
...rc/client/debugger/PythonProcessCallbackHandler.ts 52.3% <0%> (-1.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 149c066...89548de. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 3626de2 into microsoft:master Mar 26, 2018
@DonJayamanne DonJayamanne deleted the issue1168DebugOptions branch June 20, 2018 03:19
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@brettcannon brettcannon brettcannon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Changes to how debug options are passed to PTVSD (experimental debugger)

2 participants

@DonJayamanne @brettcannon