Remove 'jediEnabled' in favor of languageServer#11834
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11834 +/- ##
===========================================
- Coverage 60.67% 0.00% -60.68%
===========================================
Files 628 12 -616
Lines 33908 37 -33871
Branches 4775 4 -4771
===========================================
- Hits 20573 0 -20573
+ Misses 12344 37 -12307
+ Partials 991 0 -991
Continue to review full report at Codecov.
|
languageServer
ericsnowcurrently
left a comment
There was a problem hiding this comment.
Thanks for working on this. Mostly LGTM.
Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
ericsnowcurrently
left a comment
There was a problem hiding this comment.
LGTM
I left one comment, but I'll leave it to you to decide. 🙂
| minVersion = appEnv.packageJson[DotNetLanguageServerMinVersionKey] as string; | ||
| } | ||
| // tslint:disable-next-line: no-empty | ||
| } catch {} |
There was a problem hiding this comment.
Under what circumstances do you expect this to fail? It would probably make sense to log the error (e.g. with traceVerbose()).
|
As mentioned in #7010, previous versions of the "python.jediEnabled" setting should be migrated automatically. But this doesn't seem to happen, |
|
This PR intended to do this, setting |
|
Nope, it didn't happen here. I used to have |
|
That's not good; I'd appreciate it if you could make a new issue for it so it can be tracked. |
|
I would like to get reliably reproducible steps first, but it seems Python extension doesn't offer old versions? "Install another versions.." returns 404:
|
|
Never mind, I manually installed an older version and reproduced it. Created a ticket at #12429. |
The python.jediEnabled setting got replaced by python.languageServer [1]. Thus, update to the new format. [1] microsoft/vscode-python#11834
The python.jediEnabled setting got replaced by python.languageServer [1]. Thus, update to the new format. [1] microsoft/vscode-python#11834
The python.jediEnabled setting got replaced by python.languageServer [1]. Thus, update to the new format. [1] microsoft/vscode-python#11834
For #7010
Rely on
languageServerinstead.- [ ] Test plan is updated as appropriate.- [ ]package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).- [ ] The wiki is updated with any design decisions/details.