Skip to content

Remove APIs related to ptvsd paths#11757

Merged
karthiknadig merged 1 commit into
microsoft:logging-changes-and-drop-old-debuggerfrom
karthiknadig:remove-ptvsd-from-apis
May 12, 2020
Merged

Remove APIs related to ptvsd paths#11757
karthiknadig merged 1 commit into
microsoft:logging-changes-and-drop-old-debuggerfrom
karthiknadig:remove-ptvsd-from-apis

Conversation

@karthiknadig

@karthiknadig karthiknadig commented May 12, 2020

Copy link
Copy Markdown
Member

For #7136

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@karthiknadig karthiknadig added the no-changelog No news entry required label May 12, 2020
@kimadeline kimadeline mentioned this pull request May 12, 2020
Closed
8 tasks
@codecov-io

codecov-io commented May 12, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #11757 into logging-changes-and-drop-old-debugger will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@                            Coverage Diff                            @@
##           logging-changes-and-drop-old-debugger   #11757      +/-   ##
=========================================================================
- Coverage                                  60.72%   60.70%   -0.03%     
=========================================================================
  Files                                        629      629              
  Lines                                      34007    34003       -4     
  Branches                                    4795     4793       -2     
=========================================================================
- Hits                                       20650    20640      -10     
+ Misses                                     12364    12354      -10     
- Partials                                     993     1009      +16
Impacted Files Coverage Δ
...ient/debugger/extension/adapter/remoteLaunchers.ts 100.00% <ø> (ø)
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
src/client/logging/levels.ts 61.11% <0.00%> (ø)
src/client/logging/logger.ts 75.60% <0.00%> (ø)
src/client/logging/_global.ts 85.24% <0.00%> (ø)
src/client/logging/formatters.ts 53.57% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 063c33d...68375d6. Read the comment docs.

@karthiknadig karthiknadig marked this pull request as ready for review May 12, 2020 05:10
@karthiknadig karthiknadig force-pushed the remove-ptvsd-from-apis branch from be88390 to 68375d6 Compare May 12, 2020 05:35
@sonarqubecloud

sonarqubecloud Bot commented May 12, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

ericsnowcurrently
ericsnowcurrently approved these changes May 12, 2020
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karthiknadig karthiknadig merged commit cf62c2a into microsoft:logging-changes-and-drop-old-debugger May 12, 2020
@karthiknadig karthiknadig deleted the remove-ptvsd-from-apis branch May 12, 2020 19:05
@lock lock Bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@kimadeline kimadeline kimadeline approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@karthiknadig @codecov-io @ericsnowcurrently @kimadeline