Second refactor for non-jupyter kernel search#11527
Conversation
|
One more refactor that I wanted to roll in here for non-jupyter kernel searching |
|
Kudos, SonarCloud Quality Gate passed!
|
| @reportAction(ReportableAction.KernelsGetKernelForLocalConnection) | ||
| public async getKernelForLocalConnection( | ||
| resource: Resource, | ||
| type: 'raw' | 'jupyter' | 'noConnection', |
There was a problem hiding this comment.
Main crux of the change is to have the rawKernelProvider call into getKernelForLocalConnection to get the initial launch kernel / interpreter. This lets it participate in stuff like the prewarming of the kernel switcher selections.
| } | ||
|
|
||
| // Get our kernelspec and matching interpreter for a connection to a local jupyter server | ||
| private async getKernelForLocalJupyterConnection( |
There was a problem hiding this comment.
Just a move into a function of the jupyter specific code that was in getKernelForLocalConnection.
| // Before we try to connect we need to find a kernel and install ipykernel | ||
| const kernelSpec = await this.kernelFinder.findKernelSpec( | ||
| // We need to locate kernelspec and possible interpreter for this launch based on resource and notebook metadata | ||
| const kernelSpecInterpreter = await this.kernelSelector.getKernelForLocalConnection( |
There was a problem hiding this comment.
Pushed kernelFinder and kernelService calls into the kernel selector here.
For #
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).