Remove IJMPConnection and uses of it while maintaining same tests#11503
Merged
Conversation
DonJayamanne
approved these changes
Apr 29, 2020
DavidKutu
approved these changes
Apr 29, 2020
IanMatthewHuff
approved these changes
Apr 29, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #11503 +/- ##
===========================================
- Coverage 60.64% 39.93% -20.72%
===========================================
Files 613 613
Lines 33511 33511
Branches 4727 4727
===========================================
- Hits 20322 13381 -6941
- Misses 12740 19653 +6913
- Partials 449 477 +28
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #11470
During the IPyWidget impl for raw kernel, I stopped using the IJMPConnection stuff. This change removes it from our source and rewires the tests that were using to use the rawKernel instead.