Skip to content

Adds missing entries in the unittest ioc container for extract var tests#11493

Merged
karthiknadig merged 2 commits into
microsoft:masterfrom
karthiknadig:gha-1a
Apr 29, 2020
Merged

Adds missing entries in the unittest ioc container for extract var tests#11493
karthiknadig merged 2 commits into
microsoft:masterfrom
karthiknadig:gha-1a

Conversation

@karthiknadig
Copy link
Copy Markdown
Member

@karthiknadig karthiknadig commented Apr 29, 2020 •
edited
Loading

This should get 3.8 single workspace (ubuntu and windows) running green on GHA.
image
image

@karthiknadig karthiknadig added the no-changelog No news entry required label Apr 29, 2020
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 29, 2020 •
edited
Loading

Codecov Report

Merging #11493 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11493      +/-   ##
==========================================
- Coverage   60.63%   60.62%   -0.02%     
==========================================
  Files         613      613              
  Lines       33507    33511       +4     
  Branches     4727     4727              
==========================================
- Hits        20317    20316       -1     
+ Misses      12740    12187     -553     
- Partials      450     1008     +558
Impacted Files Coverage Δ
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
src/client/testing/main.ts 14.38% <0.00%> (ø)
src/client/common/editor.ts 8.25% <0.00%> (ø)
src/client/linters/flake8.ts 85.71% <0.00%> (ø)
src/client/linters/pylint.ts 98.27% <0.00%> (ø)
src/client/telemetry/index.ts 85.21% <0.00%> (ø)
src/client/language/unicode.ts 68.18% <0.00%> (ø)
... and 138 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96da8f1...6791084. Read the comment docs.

@karthiknadig karthiknadig marked this pull request as ready for review April 29, 2020 07:37
karrtikr
karrtikr reviewed Apr 29, 2020
View reviewed changes
Comment thread src/test/refactor/extension.refactor.extract.var.test.ts Outdated
@karthiknadig
Copy link
Copy Markdown
Member Author

karthiknadig commented Apr 29, 2020

Tests passed but github is not updating:
https://dev.azure.com/ms/vscode-python/_build/results?buildId=76553&view=results
image

@karthiknadig karthiknadig merged commit 9348a37 into microsoft:master Apr 29, 2020
@karthiknadig karthiknadig deleted the gha-1a branch April 30, 2020 23:09
@lock lock Bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@karrtikr karrtikr karrtikr approved these changes

@kimadeline kimadeline kimadeline approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@karthiknadig @codecov-io @karrtikr @kimadeline