Skip to content

Route python interpreter into kernel launcher#11486

Merged
IanMatthewHuff merged 2 commits into
microsoft:masterfrom
IanMatthewHuff:dev/ianhu/routeInterpreter
Apr 29, 2020
Merged

Route python interpreter into kernel launcher#11486
IanMatthewHuff merged 2 commits into
microsoft:masterfrom
IanMatthewHuff:dev/ianhu/routeInterpreter

Conversation

@IanMatthewHuff

Copy link
Copy Markdown
Member

For #

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@IanMatthewHuff IanMatthewHuff added the no-changelog No news entry required label Apr 28, 2020
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #11486 into master will increase coverage by 0.02%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11486      +/-   ##
==========================================
+ Coverage   60.59%   60.62%   +0.02%     
==========================================
  Files         612      613       +1     
  Lines       33482    33508      +26     
  Branches     4723     4727       +4     
==========================================
+ Hits        20289    20313      +24     
+ Misses      12743    12187     -556     
- Partials      450     1008     +558     
Impacted Files Coverage Δ
src/client/datascience/jupyter/jupyterNotebook.ts 4.21% <0.00%> (ø)
src/client/datascience/jupyter/jupyterSession.ts 74.79% <ø> (ø)
src/client/datascience/types.ts 100.00% <ø> (ø)
src/client/datascience/baseJupyterSession.ts 53.25% <100.00%> (+0.27%) ⬆️
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-5.89%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
...lient/datascience/jupyter/kernels/kernelService.ts 52.35% <0.00%> (-0.25%) ⬇️
src/client/testing/main.ts 14.38% <0.00%> (ø)
... and 143 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47b722a...78194ac. Read the comment docs.

@IanMatthewHuff IanMatthewHuff merged commit 7d316f0 into microsoft:master Apr 29, 2020
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/routeInterpreter branch April 29, 2020 16:03
@lock lock Bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants