Skip to content

Replace word "browse" with "find"#11460

Merged
kimadeline merged 5 commits into
microsoft:masterfrom
luabud:fixgrammar
Apr 29, 2020
Merged

Replace word "browse" with "find"#11460
kimadeline merged 5 commits into
microsoft:masterfrom
luabud:fixgrammar

Conversation

@luabud
Copy link
Copy Markdown
Member

@luabud luabud commented Apr 27, 2020

For discussion we had when reviewing a PR

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.

@luabud
Copy link
Copy Markdown
Member Author

luabud commented Apr 27, 2020

FYI @karrtikr @kimadeline

@luabud luabud marked this pull request as ready for review April 27, 2020 22:59
karrtikr
karrtikr suggested changes Apr 28, 2020
View reviewed changes
Copy link
Copy Markdown

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also change package.nls.json

@luabud luabud requested a review from karrtikr April 28, 2020 16:36
@luabud
Copy link
Copy Markdown
Member Author

luabud commented Apr 28, 2020

oops 🙈😅

karrtikr
karrtikr approved these changes Apr 28, 2020
View reviewed changes
Copy link
Copy Markdown

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go✔️

@kimadeline kimadeline added the no-changelog No news entry required label Apr 28, 2020
@kimadeline
Copy link
Copy Markdown

kimadeline commented Apr 28, 2020 •
edited
Loading

Linting is failing, have you run npm ci recently and formatted the files afterwards?

SonarCloud is not happy, can you try merging master in your branch?

@luabud
Copy link
Copy Markdown
Member Author

luabud commented Apr 28, 2020

I have run npm ci but haven't formatted the files afterwards.

Sure, I'll merge master in this branch.

@luabud
Copy link
Copy Markdown
Member Author

luabud commented Apr 28, 2020

SonarCloud is 😁 now but linting is 😡. Is there anything else I can try to do it make it 😁?

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 28, 2020 •
edited
Loading

Codecov Report

Merging #11460 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #11460    +/-   ##
========================================
  Coverage   60.61%   60.61%            
========================================
  Files         612      613     +1     
  Lines       33472    33508    +36     
  Branches     4719     4728     +9     
========================================
+ Hits        20290    20312    +22     
+ Misses      12731    12188   -543     
- Partials      451     1008   +557
Impacted Files Coverage Δ
src/client/common/utils/localize.ts 95.50% <ø> (ø)
src/client/constants.ts 83.33% <0.00%> (-16.67%) ⬇️
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
...lient/datascience/jupyter/kernels/kernelService.ts 52.35% <0.00%> (-2.84%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
src/client/testing/main.ts 14.38% <0.00%> (ø)
src/client/common/editor.ts 8.25% <0.00%> (ø)
... and 141 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6218433...b9aca76. Read the comment docs.

@kimadeline
Copy link
Copy Markdown

kimadeline commented Apr 28, 2020

You only formatted package.nls.json (this removed the newline at the end, but when I format this file automatically it gets re-added) but it's localize.ts that is failing linting:

image

Which formatter do you use? I have the Prettier extension installed and set as my default formatter in VS Code (editor.defaultFormatter).

@karrtikr
Copy link
Copy Markdown

karrtikr commented Apr 28, 2020

Do you have Prettier - Code formatter extension installed? Looks like you're getting some formatting errors in Hygiene.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 28, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kimadeline kimadeline merged commit baf85b9 into microsoft:master Apr 29, 2020
@karrtikr
Copy link
Copy Markdown

karrtikr commented Apr 29, 2020

@luabud would've wanted to merge it :(

@luabud
Copy link
Copy Markdown
Member Author

luabud commented Apr 29, 2020

woohooo thank you both for helping me with this 🎉🎉

awesome

@luabud luabud deleted the fixgrammar branch April 29, 2020 16:32
@lock lock Bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

+1 more reviewer

@karrtikr karrtikr karrtikr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@luabud @kimadeline @codecov-io @karrtikr @karthiknadig