Skip to content

Add telemetry for "Python is not installed" prompt#11163

Merged
kimadeline merged 6 commits into
microsoft:masterfrom
kimadeline:10885-telemetry-python-not-installed
Apr 22, 2020
Merged

Add telemetry for "Python is not installed" prompt#11163
kimadeline merged 6 commits into
microsoft:masterfrom
kimadeline:10885-telemetry-python-not-installed

Conversation

@kimadeline
Copy link
Copy Markdown

@kimadeline kimadeline commented Apr 14, 2020

For #10885

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 14, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 14, 2020

Codecov Report

Merging #11163 into master will increase coverage by 0.00%.
The diff coverage is 92.30%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #11163    +/-   ##
========================================
  Coverage   61.41%   61.41%            
========================================
  Files         596      596            
  Lines       32848    32862    +14     
  Branches     4655     4659     +4     
========================================
+ Hits        20173    20182     +9     
+ Misses      12465    11662   -803     
- Partials      210     1018   +808
Impacted Files Coverage Δ
src/client/application/diagnostics/types.ts 100.00% <ø> (ø)
src/client/telemetry/index.ts 87.38% <ø> (ø)
...pplication/diagnostics/checks/pythonInterpreter.ts 91.07% <90.00%> (-0.60%) ⬇️
...rc/client/application/diagnostics/promptHandler.ts 100.00% <100.00%> (+4.76%) ⬆️
src/client/telemetry/constants.ts 100.00% <100.00%> (ø)
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
...client/datascience/kernel-launcher/kernelFinder.ts 75.70% <0.00%> (-0.94%) ⬇️
... and 171 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eab579f...93afcfb. Read the comment docs.

@kimadeline kimadeline marked this pull request as ready for review April 15, 2020 07:51
@kimadeline kimadeline requested a review from karthiknadig April 20, 2020 17:37
@kimadeline kimadeline merged commit 48ea303 into microsoft:master Apr 22, 2020
@kimadeline kimadeline deleted the 10885-telemetry-python-not-installed branch April 22, 2020 14:57
@lock lock Bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

+1 more reviewer

@int19h int19h int19h approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kimadeline @codecov-io @int19h @karthiknadig