Skip to content

Check whether a document is active when detecthing changes in the active document#1116

Merged
DonJayamanne merged 6 commits into
microsoft:masterfrom
DonJayamanne:issue1114
Mar 20, 2018
Merged

Check whether a document is active when detecthing changes in the active document#1116
DonJayamanne merged 6 commits into
microsoft:masterfrom
DonJayamanne:issue1114

Conversation

@DonJayamanne
Copy link
Copy Markdown

@DonJayamanne DonJayamanne commented Mar 19, 2018

Fixes #1114

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)


// tslint:disable-next-line:max-func-body-length
suite('Interpreters service', () => {
suite('Interpreters servicex', () => {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oopsy, was done for testing purpsose

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 19, 2018

Codecov Report

Merging #1116 into master will decrease coverage by 0.24%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1116      +/-   ##
==========================================
- Coverage   72.13%   71.89%   -0.25%     
==========================================
  Files         260      260              
  Lines       11895    11895              
  Branches     2107     2108       +1     
==========================================
- Hits         8581     8552      -29     
- Misses       3191     3219      +28     
- Partials      123      124       +1
Impacted Files Coverage Δ
src/client/interpreter/interpreterService.ts 76.34% <100%> (ø) ⬆️
src/client/linters/errorHandlers/notInstalled.ts 33.33% <0%> (-61.12%) ⬇️
src/client/linters/errorHandlers/errorHandler.ts 77.77% <0%> (-22.23%) ⬇️
src/client/common/logger.ts 53.33% <0%> (-20.01%) ⬇️
src/client/common/application/applicationShell.ts 23.07% <0%> (-7.7%) ⬇️
src/client/common/installer/productInstaller.ts 60.31% <0%> (-4.24%) ⬇️
src/client/linters/baseLinter.ts 87.5% <0%> (-4.17%) ⬇️
...rc/client/debugger/PythonProcessCallbackHandler.ts 52.3% <0%> (-1.32%) ⬇️
src/client/debugger/mainV2.ts 73.99% <0%> (+2.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 685c3a2...d334aa0. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 2d749f0 into microsoft:master Mar 20, 2018
@DonJayamanne DonJayamanne deleted the issue1114 branch March 20, 2018 18:41
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No active document available even though onDidChangeActiveTextEditor is fired

2 participants