Skip to content

Add a Scrapy debug configuration for the experimental debugger.#1106

Merged
DonJayamanne merged 1 commit into
microsoft:masterfrom
DonJayamanne:issue1032
Mar 17, 2018
Merged

Add a Scrapy debug configuration for the experimental debugger.#1106
DonJayamanne merged 1 commit into
microsoft:masterfrom
DonJayamanne:issue1032

Conversation

@DonJayamanne
Copy link
Copy Markdown

Fixes #1032

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 17, 2018

Codecov Report

Merging #1106 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1106      +/-   ##
==========================================
- Coverage   71.67%   71.61%   -0.06%     
==========================================
  Files         260      260              
  Lines       11877    11877              
  Branches     2104     2104              
==========================================
- Hits         8513     8506       -7     
- Misses       3239     3242       +3     
- Partials      125      129       +4
Impacted Files Coverage Δ
src/client/debugger/PythonProcess.ts 47.08% <0%> (-1.67%) ⬇️
...rc/client/debugger/PythonProcessCallbackHandler.ts 51.64% <0%> (-1.32%) ⬇️
src/client/linters/lintingEngine.ts 91.22% <0%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba97e02...05d29c0. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 660508d into microsoft:master Mar 17, 2018
@DonJayamanne DonJayamanne deleted the issue1032 branch March 19, 2018 22:16
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Scrapy debugging with experimental debugger

2 participants