Skip to content

Add more UI widget tests for ipywidgets#10735

Merged
DonJayamanne merged 2 commits into
microsoft:ds/ipyWidgetsfrom
DonJayamanne:addMoreTestsForIpyWidgets
Mar 24, 2020
Merged

Add more UI widget tests for ipywidgets#10735
DonJayamanne merged 2 commits into
microsoft:ds/ipyWidgetsfrom
DonJayamanne:addMoreTestsForIpyWidgets

Conversation

@DonJayamanne

Copy link
Copy Markdown

For #10655
UI Tests for

  • ipysheet (test interaction with sheet)
  • ipyvolume (just test if canvas is rendered)
  • pythreejs (just test if canvas is rendered)

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Mar 24, 2020
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-io

codecov-io commented Mar 24, 2020

Copy link
Copy Markdown

Codecov Report

Merging #10735 into ds/ipyWidgets will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           ds/ipyWidgets   #10735      +/-   ##
=================================================
- Coverage          60.76%   60.74%   -0.02%     
=================================================
  Files                580      580              
  Lines              31448    31454       +6     
  Branches            4470     4473       +3     
=================================================
- Hits               19109    19107       -2     
- Misses             11367    11375       +8     
  Partials             972      972              
Impacted Files Coverage Δ
...ient/datascience/interactive-ipynb/nativeEditor.ts 11.28% <0.00%> (ø)
src/client/datascience/types.ts 100.00% <ø> (ø)
src/client/datascience/jupyter/jupyterSession.ts 59.59% <0.00%> (-1.16%) ⬇️
...ascience/jupyter/liveshare/guestJupyterNotebook.ts 9.37% <0.00%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 702c8ce...4403515. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 89aa703 into microsoft:ds/ipyWidgets Mar 24, 2020
@DonJayamanne DonJayamanne deleted the addMoreTestsForIpyWidgets branch March 24, 2020 15:23
@lock lock Bot locked as resolved and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants