Send telemetry when gather survey link is clicked.#10683
Merged
Conversation
And whitelist the command that does so. We don't necessarily want to open the door of being able to execute arbitrary commands to notebooks. Yet.
DonJayamanne
approved these changes
Mar 20, 2020
IanMatthewHuff
approved these changes
Mar 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #10683 +/- ##
==========================================
- Coverage 60.64% 60.62% -0.03%
==========================================
Files 583 583
Lines 31551 31557 +6
Branches 4487 4488 +1
==========================================
- Hits 19133 19130 -3
- Misses 11446 11453 +7
- Partials 972 974 +2
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
DavidKutu
approved these changes
Mar 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the top of a gathered notebook, a question is posed. "Are you satisfied with the gathered results?" (or something like that).
The user needs to click Yes or No. At that point they're choice will be sent as a telemetry event and a survey will be displayed.