Testable Kernel and Future#10679
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
| >(); | ||
|
|
||
| // JMP connection should be injected, but no need to yet until it actually exists | ||
| constructor(connection: IJMPConnection) { |
There was a problem hiding this comment.
IJMPConnection [](start = 28, length = 14)
I'm sticking this in the IOC container, so you should be able to get it from there when you create one of these.
There was a problem hiding this comment.
Yeah, once we have it I'll move it over. Right now it's a bit easier to juggle with just the constructer as I'm moving the files back over to an enlistment that has inserted the temp enchannel-zmq implementation.
Codecov Report
@@ Coverage Diff @@
## ds/rawKernel #10679 +/- ##
===============================================
Coverage ? 60.48%
===============================================
Files ? 585
Lines ? 31735
Branches ? 4500
===============================================
Hits ? 19195
Misses ? 11558
Partials ? 982
Continue to review full report at Codecov.
|
This is the kernel and future implementation that could do a exequteRequest with the old ZMQ. I've abstracted out the ZMQ bits and exercised the code with unit tests. This will let me fill out the rest of the kernel functionality while we also work on the ZMQ bits. Unit testing in as well so that it can roll that in along with the new functionality.
Note: RAWKERNEL: is my todos for areas where I know that more changes are needed.
Also pull in the mockito changes.
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).