Disable custom editor API - #10604
Merged
Don Jayamanne (DonJayamanne) merged 1 commit intoMar 17, 2020
Merged
Conversation
Don Jayamanne (DonJayamanne)
requested review from
David Kutugata (DavidKutu),
Ian Huff (IanMatthewHuff) and
Rich Chiodo (rchiodo)
March 16, 2020 23:38
|
Kudos, SonarCloud Quality Gate passed!
|
Rich Chiodo (rchiodo)
approved these changes
Mar 16, 2020
Ian Huff (IanMatthewHuff)
approved these changes
Mar 16, 2020
David Kutugata (DavidKutu)
approved these changes
Mar 16, 2020
Don Jayamanne (DonJayamanne)
added a commit
that referenced
this pull request
Mar 17, 2020
* master: Fix merge issue Move redux logging to a different file (#10605) Disable custom editor API (#10604) Ensure local host only if connection not available (#10600) Delegate management of notebooks (creation and disposing) to I… (#10568) Refactor to accommodate upstream VSCode API changes (#10569) Use a single notebook beetween multiple native editors (#10514) Add support for synchronising edits between two nb editors of… (#10189) Fix tests in ds/custom_editor branch (#10512) Fix linter Reimplement custom editor using new API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable API, then merge ds/custom_editor into master.
Then revert this PR in ds/custom_editor.
This is to keep master updated with fixes from ds/custom_editor.
Then we can minimize merge conflicts and the like when working on ds/custom_editor and ds/ipywidgets & master.
Once master has been updated with ds/custom_editor, i will revert this PR in ds/custom_editor