Skip to content

split windows PR tests up to avoid timeouts#10438

Merged
IanMatthewHuff merged 1 commit into
microsoft:masterfrom
IanMatthewHuff:dev/ianhu/splitWindowsPRTests
Mar 5, 2020
Merged

split windows PR tests up to avoid timeouts#10438
IanMatthewHuff merged 1 commit into
microsoft:masterfrom
IanMatthewHuff:dev/ianhu/splitWindowsPRTests

Conversation

@IanMatthewHuff

Copy link
Copy Markdown
Member

For #10293

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@sonarqubecloud

sonarqubecloud Bot commented Mar 4, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-io

codecov-io commented Mar 5, 2020

Copy link
Copy Markdown

Codecov Report

Merging #10438 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10438      +/-   ##
==========================================
+ Coverage   60.94%   60.94%   +<.01%     
==========================================
  Files         578      578              
  Lines       31122    31190      +68     
  Branches     4418     4429      +11     
==========================================
+ Hits        18966    19008      +42     
- Misses      11194    11216      +22     
- Partials      962      966       +4
Impacted Files Coverage Δ
src/datascience-ui/react-common/arePathsSame.ts 75% <0%> (-12.5%) ⬇️
src/client/common/utils/platform.ts 64.7% <0%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0%> (-2.23%) ⬇️
src/client/activation/node/manager.ts 28.3% <0%> (-1.7%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0%> (-0.73%) ⬇️
src/client/common/experimentGroups.ts 100% <0%> (ø) ⬆️
src/client/telemetry/constants.ts 100% <0%> (ø) ⬆️
src/client/activation/languageServer/manager.ts 83.6% <0%> (+0.84%) ⬆️
src/client/activation/languageClientMiddleware.ts 33.59% <0%> (+25.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd7175a...e3d0e1d. Read the comment docs.

@IanMatthewHuff IanMatthewHuff merged commit 4002b92 into microsoft:master Mar 5, 2020
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/splitWindowsPRTests branch March 5, 2020 16:15
@lock lock Bot locked as resolved and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants