Capture request timings in language server client middleware#10419
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10419 +/- ##
==========================================
+ Coverage 60.94% 60.94% +<.01%
==========================================
Files 578 578
Lines 31121 31188 +67
Branches 4418 4428 +10
==========================================
+ Hits 18966 19008 +42
- Misses 11194 11215 +21
- Partials 961 965 +4
Continue to review full report at Codecov.
|
DonJayamanne
approved these changes
Mar 4, 2020
Member
Author
|
Hold off on merging, I'm looking into cleaning up some of my duplication. |
|
Kudos, SonarCloud Quality Gate passed!
|
Member
Author
|
@DonJayamanne Thanks for looking. I shifted things around a little, but the general scheme is about the same. No clue why CI keeps timing out... |
|
You can ignore the timeout, it's a known issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #10392.
I'd like some feedback on some of the numbers I've chosen here. I'm using the AB test mechanism to help limit flow for the non-node LS, so it's possible I can lax some of the other limits I have.
Has a news entry file (remember to thank yourself!).Marked as skip-news. Can make an enhancement w/ news if wanted.Unit tests & system/integration tests are added/updated.Tentatively hoping this isn't needed.Test plan is updated as appropriate.package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).The wiki is updated with any design decisions/details.