Skip to content

Default uri in input to value in clipboard#10413

Merged
DonJayamanne merged 3 commits into
microsoft:masterfrom
DonJayamanne:issue9163
Mar 3, 2020
Merged

Default uri in input to value in clipboard#10413
DonJayamanne merged 3 commits into
microsoft:masterfrom
DonJayamanne:issue9163

Conversation

@DonJayamanne
Copy link
Copy Markdown

For #9163

Copy link
Copy Markdown

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

return env.clipboard.readText();
}
public async writeText(value: string): Promise<void> {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an extra space here? Did this lint ok?

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 3, 2020

Codecov Report

Merging #10413 into master will increase coverage by 0.06%.
The diff coverage is 78.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10413      +/-   ##
==========================================
+ Coverage   60.88%   60.94%   +0.06%     
==========================================
  Files         570      572       +2     
  Lines       30758    30826      +68     
  Branches     4379     4387       +8     
==========================================
+ Hits        18727    18787      +60     
- Misses      11080    11084       +4     
- Partials      951      955       +4
Impacted Files Coverage Δ
src/client/common/application/types.ts 100% <100%> (ø) ⬆️
src/client/common/serviceRegistry.ts 100% <100%> (ø) ⬆️
src/client/datascience/jupyter/serverSelector.ts 92.98% <100%> (+1.14%) ⬆️
src/client/common/application/clipboard.ts 42.85% <42.85%> (ø)
src/datascience-ui/react-common/arePathsSame.ts 75% <0%> (-12.5%) ⬇️
src/client/common/utils/platform.ts 64.7% <0%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0%> (-0.73%) ⬇️
src/client/debugger/extension/serviceRegistry.ts 100% <0%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 762d236...0dda74d. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DonJayamanne DonJayamanne merged commit 5ed5103 into microsoft:master Mar 3, 2020
@DonJayamanne DonJayamanne deleted the issue9163 branch March 3, 2020 23:43
@lock lock Bot locked as resolved and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants