Skip to content

Enable code coverage for debug adapters#1018

Merged
DonJayamanne merged 19 commits into
microsoft:masterfrom
DonJayamanne:issue778
Mar 16, 2018
Merged

Enable code coverage for debug adapters#1018
DonJayamanne merged 19 commits into
microsoft:masterfrom
DonJayamanne:issue778

Conversation

@DonJayamanne
Copy link
Copy Markdown

Fixes #778

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 10, 2018

Codecov Report

Merging #1018 into master will increase coverage by 7.67%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1018      +/-   ##
==========================================
+ Coverage   64.08%   71.76%   +7.67%     
==========================================
  Files         260      260              
  Lines       11874    12016     +142     
  Branches     2103     2135      +32     
==========================================
+ Hits         7610     8623    +1013     
+ Misses       4256     3265     -991     
- Partials        8      128     +120
Impacted Files Coverage Δ
src/client/debugger/mainV2.ts 71.1% <100%> (+71.1%) ⬆️
src/client/debugger/Main.ts 50% <50%> (+50%) ⬆️
src/client/unittests/common/debugLauncher.ts 17.64% <0%> (-75.38%) ⬇️
src/client/linters/prospector.ts 15.78% <0%> (-63.16%) ⬇️
src/client/linters/pydocstyle.ts 90.24% <0%> (-4.88%) ⬇️
src/client/linters/linterManager.ts 82.6% <0%> (-2.9%) ⬇️
...rc/client/debugger/configProviders/baseProvider.ts 90.47% <0%> (-1.59%) ⬇️
src/client/common/installer/moduleInstaller.ts 50% <0%> (-0.85%) ⬇️
src/client/linters/linterInfo.ts 100% <0%> (ø) ⬆️
src/client/common/process/proc.ts 100% <0%> (ø) ⬆️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 637efc4...5c2fa76. Read the comment docs.

@DonJayamanne
Copy link
Copy Markdown
Author

Confusing, checking this same code in my branch and running the same tests on Travis produces 70% coverage!!!

@DonJayamanne
Copy link
Copy Markdown
Author

Lol, when comparing the coverage results between master and this PR, its obvious that the coverage will increase. I guess I'm not reading the results correctly 😕

@DonJayamanne DonJayamanne changed the title Enable code coverage for debug adapters unit tests Enable code coverage for debug adapters Mar 10, 2018
@DonJayamanne DonJayamanne merged commit 0f51fd6 into microsoft:master Mar 16, 2018
@DonJayamanne DonJayamanne deleted the issue778 branch March 19, 2018 22:17
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test coverage data is not available when testing debug adapter

2 participants