Skip to content

Tag GHA CI successful build as LKG#10099

Merged
kimadeline merged 14 commits into
microsoft:masterfrom
kimadeline:gh-action-lkg-tag
Feb 13, 2020
Merged

Tag GHA CI successful build as LKG#10099
kimadeline merged 14 commits into
microsoft:masterfrom
kimadeline:gh-action-lkg-tag

Conversation

@kimadeline
Copy link
Copy Markdown

@kimadeline kimadeline commented Feb 13, 2020

For #9842

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@kimadeline kimadeline added the no-changelog No news entry required label Feb 13, 2020
@kimadeline kimadeline mentioned this pull request Feb 13, 2020
Closed
5 tasks
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 13, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 13, 2020 •
edited
Loading

Codecov Report

Merging #10099 into master will decrease coverage by 0.06%.
The diff coverage is 12.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10099      +/-   ##
==========================================
- Coverage   61.39%   61.33%   -0.07%     
==========================================
  Files         565      567       +2     
  Lines       30562    30648      +86     
  Branches     4386     4393       +7     
==========================================
+ Hits        18765    18797      +32     
- Misses      10820    10873      +53     
- Partials      977      978       +1
Impacted Files Coverage Δ
src/client/common/editor.ts 8.25% <0%> (-0.17%) ⬇️
src/client/datascience/jupyter/jupyterVariables.ts 50.86% <100%> (ø) ⬆️
src/client/datascience/jupyter/notebookStarter.ts 65.25% <0%> (-2.32%) ⬇️
...er/jupyterInterpreterSubCommandExecutionService.ts 84.16% <0%> (ø) ⬆️
...c/datascience-ui/react-common/settingsReactSide.ts 22.22% <0%> (ø) ⬆️
src/client/datascience/jupyter/jupyterExecution.ts 50% <0%> (ø) ⬆️
src/client/common/types.ts 100% <0%> (ø) ⬆️
...client/datascience/commands/commandLineSelector.ts 38.46% <0%> (ø)
.../client/datascience/jupyter/commandLineSelector.ts 22.91% <0%> (ø)
src/client/datascience/constants.ts 99.69% <0%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3fc993...6047881. Read the comment docs.

@kimadeline kimadeline marked this pull request as ready for review February 13, 2020 16:21
@kimadeline kimadeline merged commit 7fbd614 into microsoft:master Feb 13, 2020
@kimadeline kimadeline deleted the gh-action-lkg-tag branch February 13, 2020 19:21
@lock lock Bot locked as resolved and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

@karrtikr karrtikr Awaiting requested review from karrtikr

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kimadeline @codecov-io @karthiknadig