Skip to content

Perf improve to load time of extension#10095

Merged
DonJayamanne merged 2 commits into
microsoft:masterfrom
DonJayamanne:perfImprove
Feb 13, 2020
Merged

Perf improve to load time of extension#10095
DonJayamanne merged 2 commits into
microsoft:masterfrom
DonJayamanne:perfImprove

Conversation

@DonJayamanne
Copy link
Copy Markdown

@DonJayamanne DonJayamanne commented Feb 12, 2020

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Feb 12, 2020
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 12, 2020

Codecov Report

Merging #10095 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10095      +/-   ##
==========================================
- Coverage   61.39%   61.33%   -0.06%     
==========================================
  Files         565      567       +2     
  Lines       30566    30648      +82     
  Branches     4387     4393       +6     
==========================================
+ Hits        18765    18797      +32     
- Misses      10824    10873      +49     
- Partials      977      978       +1
Impacted Files Coverage Δ
src/client/datascience/jupyter/notebookStarter.ts 65.25% <0%> (-2.32%) ⬇️
...er/jupyterInterpreterSubCommandExecutionService.ts 84.16% <0%> (ø) ⬆️
...c/datascience-ui/react-common/settingsReactSide.ts 22.22% <0%> (ø) ⬆️
src/client/datascience/jupyter/jupyterExecution.ts 50% <0%> (ø) ⬆️
src/client/common/types.ts 100% <0%> (ø) ⬆️
...client/datascience/commands/commandLineSelector.ts 38.46% <0%> (ø)
.../client/datascience/jupyter/commandLineSelector.ts 22.91% <0%> (ø)
src/client/datascience/constants.ts 99.69% <0%> (ø) ⬆️
src/client/common/utils/localize.ts 95.26% <0%> (+0.1%) ⬆️
src/client/datascience/commands/commandRegistry.ts 29.18% <0%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a7484b...21cf038. Read the comment docs.

@DonJayamanne DonJayamanne merged commit dc0ed96 into microsoft:master Feb 13, 2020
@DonJayamanne DonJayamanne deleted the perfImprove branch February 13, 2020 01:35
@lock lock Bot locked as resolved and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants