Repository navigation
feat: Support new file contribution - #533
Merged
Merged
Conversation
Sheng Chen (jdneo)
requested review from
Shi Chen (CsCherrYY),
Yan Zhang (Eskibear) and
Jinbo Wang (testforstephen)
August 10, 2021 07:29
Sheng Chen (jdneo)
force-pushed
the
cs/newFile
branch
from
August 11, 2021 02:44
0530580 to
54a33cf
Compare
Member
|
LGTM, and suggest to support full qualified class name in future? |
Sheng Chen (jdneo)
force-pushed
the
cs/newFile
branch
from
August 12, 2021 07:54
08289ab to
2c25fc0
Compare
Member
Author
|
Change the logic to:
|
Yan Zhang (Eskibear)
previously approved these changes
Aug 12, 2021
Member
Author
|
Appended a commit. Now if there is no active text editor but having one source path, the source path will be returned as the package path. This is useful in invisible projects. |
Sheng Chen (jdneo)
force-pushed
the
cs/newFile
branch
from
August 12, 2021 12:19
0d733d3 to
40ee541
Compare
Member
|
why Linux-UI failed, is it unstable? |
Member
Author
|
Yes it's unstable |
Yan Zhang (Eskibear)
approved these changes
Aug 13, 2021
17 tasks done
Member
Author
|
We might need to revisit this feature once we can get the selected file path from the file explorer. See: microsoft/vscode#3553 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve microsoft/vscode-java-pack#706