Skip to content

refactor: Fix unused locals/parameters and implicit returns - #371

Merged
Sheng Chen (jdneo) merged 10 commits into
microsoft:masterfrom
xqzlgy2:tsconfig
Nov 24, 2020
Merged

Sheng Chen (jdneo) merged 10 commits into
microsoft:masterfrom
xqzlgy2:tsconfig

Conversation

@xqzlgy2

Copy link
Copy Markdown
Contributor

This PR enabled TS compiler check for:

  • Unused import/local variables
  • Unused function parameters
  • Implicit this/return

Also fixed existing errors.

#368

@jdneo

Copy link
Copy Markdown
Member

Qinzhou Xu (@xqzlgy2) Some conflicts need to resolve.

@jdneo Sheng Chen (jdneo) added the eng engineering label Nov 23, 2020
@jdneo Sheng Chen (jdneo) added this to the 0.16.0 milestone Nov 23, 2020
Comment thread src/views/containerNode.ts Outdated
@jdneo
Sheng Chen (jdneo) merged commit 3e41544 into microsoft:master Nov 24, 2020
@xqzlgy2
Qinzhou Xu (xqzlgy2) deleted the tsconfig branch November 24, 2020 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

eng engineering

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants