Repository navigation
Support managing referenced libraries - #213
Merged
Merged
Conversation
Vigilans (Vigilans)
force-pushed
the
vigilans/referencedLibraries
branch
from
November 19, 2019 20:21
1f26a1e to
55cd56c
Compare
Vigilans (Vigilans)
force-pushed
the
vigilans/referencedLibraries
branch
from
November 26, 2019 08:15
a54ba39 to
db6fc92
Compare
Vigilans (Vigilans)
marked this pull request as ready for review
November 27, 2019 05:09
Contributor
|
what's the status for this PR? |
Member
Author
|
Some important modifications are saved in my Linux PC. May I rebase to the master branch and update the PR after going back home tonight? |
* Notification dependency viewer to refresh on updating classpath done * Command to manually trigger classpath refreshing
Vigilans (Vigilans)
force-pushed
the
vigilans/referencedLibraries
branch
from
December 28, 2019 08:00
812caed to
f9d4af4
Compare
* Adding file/folder to referenced libraries * Removing a jar file from referenced libraries * Manually trigger refreshing of referenced libraries in classpath
Vigilans (Vigilans)
force-pushed
the
vigilans/referencedLibraries
branch
from
December 28, 2019 14:09
f9d4af4 to
3b8f1c6
Compare
Jinbo Wang (testforstephen)
requested changes
Dec 31, 2019
Sheng Chen (jdneo)
previously approved these changes
Jan 7, 2020
| })); | ||
| } | ||
| const setting = Settings.referencedLibraries(); | ||
| setting.include.push(...libraryGlobs); |
Member
There was a problem hiding this comment.
Simply push might not work in some scenario, like:
if the original setting is:
"java.project.referencedLibraries": {
"include": [
"lib/**/*.jar"
],
"exclude": [
"lib/junit-platform-console-standalone-1.5.2.jar"
]
}where the junit-platform-console-standalone-1.5.2.jar is the only jar in the lib folder.
Now if I re-add the lib folder into the referenced libs, the exclude part won't be updated.
Jinbo Wang (testforstephen)
previously approved these changes
Jan 8, 2020
Jinbo Wang (testforstephen)
previously approved these changes
Jan 8, 2020
Jinbo Wang (testforstephen)
approved these changes
Jan 13, 2020
This was referenced Jan 13, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #174, microsoft/vscode-java-pack#94
Based on:
VS Code will take care of the file watching and searching work by providng a setting:
...with the following extended behaviors before sending to
jdt.ls:includefield.lib/but notincludedwill be appended toexcludefield. It is to ensure jars not listened by VS Code don't get shown in referenced libraries — only one source of truth. (This is not an elegent workaround, waiting for better alternative...)foo.jarandfoo-src.jar(not necessarily in the same folder) will be added to sources mapping.