Skip to content

Only pop-up build errors notification when the errors are on the running project's classpath#1263

Merged
testforstephen merged 1 commit into
microsoft:mainfrom
testforstephen:jinbo_build
Nov 21, 2022
Merged

Only pop-up build errors notification when the errors are on the running project's classpath#1263
testforstephen merged 1 commit into
microsoft:mainfrom
testforstephen:jinbo_build

Conversation

@testforstephen
Copy link
Copy Markdown
Contributor

Fixes #1214
Requires microsoft/java-debug#459

  • For a build-tool managed project, will check if the running project and its references projects contain build errors. If so, report build failure. Otherwise, return succeed.
  • For unmanaged folder, only check if the running main class contains build errors. If so, report build failure. Otherwise, return succeed.
  • Add a "Always Continue" button in case users want to always continue on build failure.

Copy link
Copy Markdown
Member

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@CsCherrYY I remember there is a copy for the build stuff in project manager when exporting jar files. Could you please check if we need to update there as well?

@CsCherrYY
Copy link
Copy Markdown
Contributor

Could you please check if we need to update there as well?

looks like we should. But the new command vscode.java.buildWorkspace is contributed via java-debug jdtls plugin and now project manager doesn't have hard dependency on the debugger extension, looks like we should assert if the command is exists at first.

Or can we consider to move the command to jdtls side?

@CsCherrYY
Copy link
Copy Markdown
Contributor

And the logics at the project manager side can be reviewed. E.g., we can only build the given project, instead of the whole workspace, than we can benefit from this change.

@jdneo
Copy link
Copy Markdown
Member

jdneo commented Nov 17, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimize the build error report of "Build failed, do you want to continue?"

3 participants