Skip to content

Web - run smoke tests using playwright#89918

Merged
bpasero merged 10 commits into
masterfrom
ben/web-playwright
Feb 4, 2020
Merged

Web - run smoke tests using playwright#89918
bpasero merged 10 commits into
masterfrom
ben/web-playwright

Conversation

@bpasero
Copy link
Copy Markdown
Contributor

@bpasero bpasero commented Feb 3, 2020

This replaces puppeteer with playwright and adds support for --browser <chromium|firefox|safari>

@bpasero bpasero self-assigned this Feb 3, 2020
@bpasero bpasero added this to the February 2020 milestone Feb 3, 2020
@bpasero bpasero requested a review from Tyriar February 3, 2020 11:55
@bpasero
Copy link
Copy Markdown
Contributor Author

bpasero commented Feb 3, 2020

@Tyriar one thing I could not figure out: after the test finishes, the server instance seem to hang around and as such I cannot run the same test again because the port 9888 is blocked. I see there is code in place to kill the server but that does not seem to work? Curious if you noticed that as well.

@bpasero
Copy link
Copy Markdown
Contributor Author

bpasero commented Feb 3, 2020

@Tyriar nevermind my question, I figured out how to configure the server so that it would automatically close when the connection closes. It works fine now.

@bpasero
Copy link
Copy Markdown
Contributor Author

bpasero commented Feb 3, 2020

I think this is good for a review. Follow up work:

  • figure out why some of the tests are disabled for web specifically
  • verify this works on Windows (seems broken) and Linux

@bpasero
Copy link
Copy Markdown
Contributor Author

bpasero commented Feb 3, 2020

Pushed a fix for Windows.

@Tyriar
Copy link
Copy Markdown
Contributor

Tyriar commented Feb 3, 2020

Still seems to be broken on Windows?

image

@bpasero
Copy link
Copy Markdown
Contributor Author

bpasero commented Feb 4, 2020

@Tyriar they seem to work fine for me on Windows with latest commits in this PR. Did you run "cd test/automation && tsc" to compile to latest?

@Tyriar
Copy link
Copy Markdown
Contributor

Tyriar commented Feb 4, 2020

That's better, it still gets stuck on the first test though:

image

The quick pick appears to open before the remote is fully connected to.

@bpasero
Copy link
Copy Markdown
Contributor Author

bpasero commented Feb 4, 2020

@Tyriar the test is flaky, I doubt this is related to playwright. We should fix flaky tests as a follow up, this is a team efford we are doing this milestone.

@bpasero bpasero merged commit ec41f20 into master Feb 4, 2020
@bpasero bpasero deleted the ben/web-playwright branch February 4, 2020 16:23
@pavelfeldman
Copy link
Copy Markdown
Member

@Tyriar the test is flaky, I doubt this is related to playwright.

Might be related - @dgozman and myself saw a race there when VS Code was overwriting something already typed into that box. It looked like a real problem that could happen in the wild back then.

@github-actions github-actions Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants