Add call hierarchy support for TypeScript 3.8#88168
Merged
mjbvz merged 3 commits intomicrosoft:masterfrom Jan 8, 2020
Merged
Conversation
rbuckton
commented
Jan 6, 2020
mjbvz
requested changes
Jan 6, 2020
Collaborator
mjbvz
left a comment
There was a problem hiding this comment.
Thanks for handling this!
The main change is that we can't bundle TS 3.8 with VS Code yet. Instead, let's just copy over the new TS types related to call hierarchy and keep using the TS 3.7 for everything else
Member
|
🕺 this is soo exciting |
Author
I'll update the PR shortly, that's actually how I had it set up before creating the PR. |
8f9908f to
870edea
Compare
mjbvz
approved these changes
Jan 8, 2020
Collaborator
|
Thanks! We'll ship VS Code 1.42 with support for call hierarchy support but users will still need to update to TS 3.8 Once we pick up TS 3.8 with VS code 1.43, it will be available to everyone. I'll also remove the copied over protocol types at that point |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds Call Hierarchy support for TypeScript 3.8 and is the other half of microsoft/TypeScript#35176.
Related: #16110, microsoft/TypeScript#31863
cc: @mjbvz, @jrieken