Skip to content

Add better guards for Specialized Subagents and BG Todo Agent#319978

Merged
bhavyaus merged 7 commits into
mainfrom
vritant24-byokGuard
Jun 5, 2026
Merged

Add better guards for Specialized Subagents and BG Todo Agent#319978
bhavyaus merged 7 commits into
mainfrom
vritant24-byokGuard

Conversation

@vritant24
Copy link
Copy Markdown
Member

@vritant24 vritant24 commented Jun 4, 2026

  • Enable the background Todo Agent only for signed-in users with a paid plan and when requests are routed through CAPI.
  • Remove incorrect usage of the ownsAuthorization property for specialized subagents and check if the endpoint for the main agent is going through CAPI.

Copilot AI review requested due to automatic review settings June 4, 2026 18:26
@vritant24 vritant24 self-assigned this Jun 4, 2026
Copilot AI reviewed Jun 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@vritant24 vritant24 requested a review from Copilot June 4, 2026 18:29
Copilot AI reviewed Jun 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@vritant24 vritant24 marked this pull request as ready for review June 4, 2026 18:36
@vritant24 vritant24 requested a review from Copilot June 4, 2026 18:47
@vritant24 vritant24 assigned bhavyaus and unassigned vritant24 Jun 4, 2026
dmitrivMS
dmitrivMS previously approved these changes Jun 4, 2026
View reviewed changes
Copilot AI reviewed Jun 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 8/8 changed files
  • Comments generated: 7

Comment thread extensions/copilot/src/extension/intents/node/agentIntent.ts Outdated
Comment thread extensions/copilot/src/extension/intents/node/askAgentIntent.ts Outdated
Comment thread extensions/copilot/src/extension/intents/node/editCodeIntent2.ts Outdated
Comment thread extensions/copilot/src/extension/intents/node/notebookEditorIntent.ts Outdated
Comment thread extensions/copilot/src/extension/intents/node/agentIntent.ts Outdated
Comment thread extensions/copilot/src/extension/intents/node/test/backgroundTodoEnablement.spec.ts
Comment thread extensions/copilot/src/extension/intents/node/agentIntent.ts
Copilot stopped reviewing on behalf of vritant24 due to an error June 4, 2026 19:26
Copilot had to stop work due to a timeout.
Copilot stopped reviewing on behalf of vritant24 due to an error June 4, 2026 19:30
Copilot had to stop work due to a timeout.
@bhavyaus bhavyaus merged commit 38046b5 into main Jun 5, 2026
25 checks passed
@bhavyaus bhavyaus deleted the vritant24-byokGuard branch June 5, 2026 05:33
@vs-code-engineering vs-code-engineering Bot added this to the 1.124.0 milestone Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@dmitrivMS dmitrivMS dmitrivMS approved these changes

@bhavyaus bhavyaus bhavyaus approved these changes

Assignees

@bhavyaus bhavyaus

Labels

None yet

Projects

None yet

Milestone

1.124.0

Development

Successfully merging this pull request may close these issues.

4 participants

@vritant24 @dmitrivMS @bhavyaus