Fire chat input state commands with correct arguments#308630
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Apr 8, 2026
Merged
Fire chat input state commands with correct arguments#308630mjbvz merged 1 commit intomicrosoft:mainfrom
mjbvz merged 1 commit intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the chat sessions proposed API and extension-host plumbing so chat session option-group commands can be invoked with the correct context (including current inputState), and so chat agent invocations receive that inputState via ChatSessionContext.
Changes:
- Extend
ChatSessionContext(proposed API) to includeinputStateand deprecateinitialSessionOptions. - Add extension-host support to resolve input state for a session and wrap option-group commands via proxy commands to pass
{ inputState, sessionResource }. - Populate
chatSessionContext.inputStatewhen invoking chat agents from session-backed requests, and update Copilot tests accordingly.
Show a summary per file
| File | Description |
|---|---|
| src/vscode-dts/vscode.proposed.chatSessionsProvider.d.ts | Adds ChatSessionContext.inputState, deprecates initialSessionOptions, and updates command argument docs. |
| src/vs/workbench/api/common/extHostChatSessions.ts | Introduces input-state resolution and command-wrapping proxy logic for option-group commands. |
| src/vs/workbench/api/common/extHostChatAgents2.ts | Resolves and attaches inputState onto chatSessionContext during agent invocation. |
| src/vs/workbench/api/common/extHost.api.impl.ts | Wires ExtHostChatSessions into ExtHostChatAgents2 construction. |
| extensions/copilot/src/extension/chatSessions/vscode-node/test/claudeChatSessionContentProvider.spec.ts | Updates mocks to satisfy new ChatSessionContext.inputState requirement. |
Copilot's findings
- Files reviewed: 4/5 changed files
- Comments generated: 1
roblourens
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @DonJayamanne