Skip to content

sessions: darken light theme panel card borders#308624

Merged
hawkticehurst merged 2 commits intomainfrom
copilot/biological-lungfish
Apr 9, 2026
Merged

sessions: darken light theme panel card borders#308624
hawkticehurst merged 2 commits intomainfrom
copilot/biological-lungfish

Conversation

@hawkticehurst
Copy link
Copy Markdown
Member

@hawkticehurst hawkticehurst commented Apr 8, 2026

Summary

  • darken the chat, changes/files, and terminal card borders in the sessions app for light themes only
  • keep dark and high-contrast themes on their existing border behavior
  • update src/vs/sessions/LAYOUT.md to document the light-theme-only border override
Screenshot 2026-04-08 at 6 05 51 PM Screenshot 2026-04-08 at 6 05 45 PM

Why

The light theme panel cards needed more separation from the surrounding sessions surface without changing the darker theme treatments.

Testing

  • npm run compile-check-ts-native
  • node --experimental-strip-types build/hygiene.ts src/vs/sessions/browser/media/style.css
  • npm run valid-layers-check

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 8, 2026 22:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the Sessions (Agents) window light-theme styling to increase visual separation of the card-like parts by darkening their borders, and documents the styling rule in the Sessions layout spec.

Changes:

  • Added a light-theme-only CSS override to use editorWidget.border for chat, auxiliary bar, and panel card borders.
  • Updated src/vs/sessions/LAYOUT.md to document the light-theme-only border override and record the change in the changelog.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/vs/sessions/LAYOUT.md Documents the light-theme-only border override for card-like parts and records the change in the layout changelog.
src/vs/sessions/browser/media/style.css Adds a .vs-scoped rule to darken card borders in light themes using editorWidget.border.

Comment thread src/vs/sessions/LAYOUT.md Outdated
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@hawkticehurst hawkticehurst merged commit 791d6f2 into main Apr 9, 2026
23 checks passed
@hawkticehurst hawkticehurst deleted the copilot/biological-lungfish branch April 9, 2026 05:25
@vs-code-engineering vs-code-engineering Bot added this to the 1.116.0 milestone Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants