Repository navigation
Adding the possibility to scroll up and down the editor hover widget - #176057
Merged
Merged
Conversation
…user wishes to change them.
…the hover, when visible
Aiday Marlen Kyzy (aiday-mar)
marked this pull request as ready for review
March 7, 2023 15:35
Aiday Marlen Kyzy (aiday-mar)
requested a review
from Martin Aeschlimann (aeschli)
March 7, 2023 15:35
Martin Aeschlimann (aeschli)
approved these changes
Mar 8, 2023
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #69836
This PR adds code in order to allow the user to scroll the hover widget using the keyboard. If the content hover is visible, it is possible to focus the hover and then use the arrow up, arrow down, page up and page down keys to navigate in the hover. Provided the hover is visible, the default keybindings for focusing the hover are
cmd+k cmd+i, the same as the keybindings to toggle the hover. It is also possible to define settings in thekeybindings.jsonfile to specify if the hover should automatically be focused when triggered by the keyboard. By default, this is false.Screen.Recording.2023-03-07.at.16.10.15.mov