Repository navigation
[rush] Support for PNPM 4 (Experimental) - #1577
Merged
Ian Clanton-Thuon (iclanton) merged 13 commits intoOct 16, 2019
Merged
Conversation
…into sachinjoseph/SupportForPnpm4
…rosoft/web-build-tools into sachinjoseph/SupportForPnpm4
…into sachinjoseph/SupportForPnpm4
…into sachinjoseph/SupportForPnpm4
Apostolis Haitalis (apostolisms)
approved these changes
Oct 9, 2019
| *.pid.lock | ||
|
|
||
| # Visual Studio Code | ||
| .vscode |
Collaborator
There was a problem hiding this comment.
Should we exclude these folders entirely? Currently we have added some .vscode/launch.json files to Git as templates.
Contributor
Author
There was a problem hiding this comment.
Even though I don't feel very strongly about this change, launch.json shows up as modified every time someone changes some local debug config - which is quite an inconvenience. How about we explicitly mark template folders as include in .gitignore?
There was a problem hiding this comment.
I'm in favor of ignoring.
1 of 2 tasks
| @@ -207,13 +212,8 @@ export class PnpmLinkManager extends BaseLinkManager { | |||
|
|
|||
| // tslint:disable-next-line:max-line-length | |||
| // e.g.: C:\wbt\common\temp\node_modules\.local\C%3A%2Fwbt%2Fcommon%2Ftemp%2Fprojects%2Fapi-documenter.tgz\node_modules | |||
Contributor
There was a problem hiding this comment.
This doesn't necessarily match anymore. Maybe make a note on the comment?
Daniel (D4N14L)
approved these changes
Oct 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested rush install and rush build on web-build-tools.
Reference: https://github.com/pnpm/pnpm/releases/tag/v4.0.0