android add google diff-match-patch - #1393
Conversation
|
|
|
|
||
| CodePushUtils.log("The update contents succeeded the code signing check."); | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
If you mean just the last brace then it is mean that you added new line at the end of file. Possible it is so because your automation code-style generator added this new line.
There was a problem hiding this comment.
thanks, it's right, i found the answer when open with sublime text2.
6204fdc to
6a0298e
Compare
|
Hi lisong , Could you please clarify more detailed about your PR? What exactly issue you solved with this PR and what approach have you used? Thanks, |
|
Alexander Goncharov (@alexandergoncharov) thanks for reply! it's for #626 , it's useful features. i wonder if necessary, i will finish the mac and windows platform. |
|
lisong , thanks. It is logic changes and it require more time for investigate and test it. Sorry for this delay. |
|
I see. it is need change server too. |
|
Hey there! lisong Awesome work on this PR. Text file diff would definitely be a wonderful addition to CodePush. Unfortunately, we’re planning on completely re-writing our SDK and service logic in the near future so this is something we don’t think we can commit to at the moment on our end. On the bright side, this is something we actually plan on implementing along with these updates. While I don’t have an ETA on this, it is currently in our roadmap for the future of CodePush 😁 |
|
OK |
|
How is it now? Zakeel M. (@Zakeelm) |
1 similar comment
|
How is it now? Zakeel M. (@Zakeelm) |
|
Any news on text diff now? what about microsoft's roadmap. Zakeel M. (@Zakeelm) |
|
How is it now? Zakeel M. (@Zakeelm) |
Add patchedFiles in
hotcodepush.jsonwhich is use google diff-match-patch tools. this PR is works in android.