Skip to content

Create app using redis and improve README#2

Merged
luabud merged 21 commits intomainfrom
usingredis
Oct 23, 2023
Merged

Create app using redis and improve README#2
luabud merged 21 commits intomainfrom
usingredis

Conversation

@luabud
Copy link
Copy Markdown
Member

@luabud luabud commented Oct 14, 2023 •
edited
Loading

In this PR:

  • Adding a devcontainer.json using the community contributed "Redis Server" feature
  • Creating a main.py file with an app that allows users to add, list and remove items from a grocery list
  • Defining an ItemPayload for grocery items that contain an id, a name and a quantity in models.py
  • Adding a flushdb.py that deletes all the data for testing purposes
  • Adding a proper README

@luabud luabud marked this pull request as ready for review October 14, 2023 01:03
@luabud
Copy link
Copy Markdown
Member Author

luabud commented Oct 14, 2023

Draft of the new docs page is here: https://github.com/luabud/vscode-docs/pull/3/files

@luabud luabud requested a review from cwebster-99 October 14, 2023 03:25
pamelafox
pamelafox reviewed Oct 15, 2023
View reviewed changes
Comment thread main.py Outdated
Comment thread main.py Outdated
Comment thread main.py
Comment thread main.py Outdated
cwebster-99
cwebster-99 reviewed Oct 16, 2023
View reviewed changes
Comment thread README.md Outdated
tonybaloney
tonybaloney reviewed Oct 19, 2023
View reviewed changes
Comment thread requirements.txt
@luabud luabud merged commit 91c0936 into main Oct 23, 2023
@luabud luabud deleted the usingredis branch October 24, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pamelafox pamelafox pamelafox left review comments

@tonybaloney tonybaloney tonybaloney left review comments

@cwebster-99 cwebster-99 cwebster-99 left review comments

+1 more reviewer

@brettcannon brettcannon brettcannon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@luabud @brettcannon @pamelafox @tonybaloney @cwebster-99