chore: consolidate aria parser in isomorphic bundle#34298
Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom Jan 10, 2025
Merged
chore: consolidate aria parser in isomorphic bundle#34298pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman merged 1 commit intomicrosoft:mainfrom
Conversation
yury-s
approved these changes
Jan 10, 2025
yury-s
reviewed
Jan 10, 2025
| // - child | ||
| const valueIsSequence = value instanceof yaml.YAMLSeq ; | ||
| if (valueIsSequence) { | ||
| convertSeq(childNode, value as yamlTypes.YAMLSeq); |
Member
There was a problem hiding this comment.
Can we drop the cast after the check?
Suggested change
| convertSeq(childNode, value as yamlTypes.YAMLSeq); | |
| convertSeq(childNode, value); |
d9bcf9f to
b89ac49
Compare
Contributor
Test results for "tests 1"10 flaky37571 passed, 648 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.