Skip to content

docs: fix android launchBrowser.pkg option#34262

Merged
Skn0tt merged 1 commit intomicrosoft:mainfrom
Skn0tt:android-fix-docs
Jan 10, 2025
Merged

docs: fix android launchBrowser.pkg option#34262
Skn0tt merged 1 commit intomicrosoft:mainfrom
Skn0tt:android-fix-docs

Conversation

@Skn0tt
Copy link
Copy Markdown
Member

@Skn0tt Skn0tt commented Jan 9, 2025

Closes #34259

Looks like there was a copy&paste error when documenting the pkg paramter. The title says pkg, but the body says command.

@Skn0tt Skn0tt requested review from Copilot and dgozman January 9, 2025 11:07
@Skn0tt Skn0tt self-assigned this Jan 9, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 9, 2025

Test results for "tests 1"

3 failed
❌ [installation tests] › tests/playwright-electron-should-work.spec.ts:21:5 › electron should work @package-installations-ubuntu-latest
❌ [installation tests] › tests/playwright-electron-should-work.spec.ts:31:5 › electron should work with special characters in path @package-installations-ubuntu-latest
❌ [installation tests] › tests/playwright-electron-should-work.spec.ts:44:5 › should work when wrapped inside @playwright/test and trace is enabled @package-installations-ubuntu-latest

7 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsertype-launch.spec.ts:22:3 › should reject all promises when browser is closed @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/signals.spec.ts:86:7 › signals › should close the browser on SIGTERM @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:169:1 › should complain about newer version of trace in old viewer @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-set-input-files.spec.ts:147:3 › should upload large file @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-set-input-files.spec.ts:205:3 › should upload multiple large files @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37542 passed, 648 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Seems the command options of launchBrowser for Antroid testing does not work

3 participants